8000 add brute force enabled so we can render switch by edewit · Pull Request #34282 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

add brute force enabled so we can render switch - #34282

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
edewit:issue-34065
Oct 25, 2024
Merged

ssilvert merged 1 commit into
keycloak:mainfrom
edewit:issue-34065

Conversation

@edewit
@edewit edewit commented Oct 24, 2024
Copy link
Copy Markdown
Contributor

fixes: #34065
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

fixes: keycloak#34065
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
edewit requested a review from a team as a code owner October 24, 2024 06:53
@edewit edewit self-assigned this Oct 24, 2024
@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (ubuntu-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (ubuntu-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@ssilvert
ssilvert merged commit 4d25128 into keycloak:main Oct 25, 2024
@edewit
edewit deleted the issue-34065 branch October 25, 2024 13:25
@xgp
xgp commented Oct 25, 2024
Copy link
Copy Markdown
Contributor

Thank you @edewit and @ssilvert !!

edewit added a commit to edewit/keycloak that referenced this pull request Oct 30, 2024
fixes: keycloak#34065

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 4d25128)
stianst pushed a commit that referenced this pull request Nov 12, 2024
fixes: #34065

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 4d25128)
@edewit edewit mentioned this pull request Nov 19, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users without view-realm can't see user lockout state in Admin UI

3 participants

0