8000 fix: corrects cli arg stringification (#34156) by shawkins · Pull Request #34254 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: corrects cli arg stringification (#34156) - #34254

Merged
vmuzikar merged 1 commit into
keycloak:release/26.0from
shawkins:backport-34156-26.0
Oct 23, 2024
Merged

fix: corrects cli arg stringification (#34156)#34254
vmuzikar merged 1 commit into
keycloak:release/26.0from
shawkins:backport-34156-26.0

Conversation

@shawkins
@shawkins shawkins commented Oct 23, 2024
Copy link
Copy Markdown
Contributor

closes: #34155

Signed-off-by: Steve Hawkins shawkins@redhat.com
(cherry picked from commit 358d234)

@shawkins
fix: corrects cli arg stringification (keycloak#34156)
a24bccc 
closes: keycloak#34155

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 358d234)
@shawkins
shawkins requested review from a team as code owners October 23, 2024 12:57
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 23, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 23, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test
8000

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 23, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 23, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test

@vmuzikar
vmuzikar merged commit f300fb8 into keycloak:release/26.0 Oct 23, 2024
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shawkins @vmuzikar
0