8000 fix: refines the provider caching logic by shawkins · Pull Request #34220 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: refines the provider caching logic - #34220

Merged
shawkins merged 1 commit into
keycloak:mainfrom
shawkins:iss34219
Oct 23, 2024
Merged

shawkins merged 1 commit into
keycloak:mainfrom
shawkins:iss34219

Conversation

@shawkins
Copy link
Copy Markdown
Contributor

closes: #34219

@shawkins
shawkins requested a review from a team as a code owner October 22, 2024 22:45
@shawkins shawkins changed the title fix: reinfes the provider caching logic fix: refines the provider caching logic Oct 22, 2024
closes: keycloak#34219

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shawkins. It's a good improvement, hashcode doesn't guarantee uniqueness anyway.

I'd like to ask @keycloak/core to review as well.

@sguilhen sguilhen left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@pedroigor ^

@shawkins
shawkins merged commit 964f6b9 into keycloak:main Oct 23, 2024
@pedroigor pedroigor left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should backport it too.

shawkins added a commit to shawkins/keycloak that referenced this pull request Oct 23, 2024
closes: keycloak#34219

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 964f6b9)
@shawkins
Copy link
Copy Markdown
Contributor Author

I think we should backport it too.

#34271

pedroigor pushed a commit that referenced this pull request Oct 24, 2024
closes: #34219

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 964f6b9)
@edewit edewit mentioned this pull request Nov 19, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refine KeycloakSession provider caching

4 participants

0