8000 BACKPORT: reset error in error dialog (#34203) by edewit · Pull Request #34211 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

BACKPORT: reset error in error dialog (#34203) - #34211

Merged
stianst merged 1 commit into
keycloak:release/26.0from
edewit:backport-34203-26.0
Oct 23, 2024
Merged

BACKPORT: reset error in error dialog (#34203)#34211
stianst merged 1 commit into
keycloak:release/26.0from
edewit:backport-34203-26.0

Conversation

@edewit
@edewit edewit commented Oct 22, 2024
Copy link
Copy Markdown
Contributor

backport: #34203
fixes: #33968

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com
(cherry picked from commit 34f0901)

@edewit
reset error in error dialog (keycloak#34203)
688ab38 
fixes: keycloak#33968

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 34f0901)
@edewit
edewit requested a review from a team as a code owner October 22, 2024 17:50
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 22, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 22, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.ElementClickInterceptedException: 
element click intercepted: Element <input type="submit" class="pf-v5-c-button pf-v5-c-button pf-m-primary btn-lg" id="saveRecoveryAuthnCodesBtn" value="Complete setup" disabled=""> is not clickable at point (1769, 1393). Other element would receive the click: <form action="https://localhost:8543/auth/realms/test/login-actions/required-action?session_code=O9RlTfxwKIdshcyOeebEFVfXm3Bx9DW_TZ6imd6Ok2w&amp;execution=CONFIGURE_RECOVERY_AUTHN_CODES&amp;client_id=test-app&amp;tab_id=5vKkIqy9s9Y&amp;client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIiwic3QiOiI1MmU3NzNiZS03NjkzLTQzMjctYTM3My03ZWU0MzBjZjhiMDYifQ" class="pf-v5-c-form__group" id="kc-recovery-codes-settings-form" method="post">...</form>
  (Session info: chrome=130.0.6723.58)
Build info: version: '4.21.0', revision: '79ed462ef4'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '21.0.4'
...

Report flaky test

@stianst
stianst merged commit e3bc989 into keycloak:release/26.0 Oct 23, 2024
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @stianst
0