8000 Change order of absolute path and normalize in the theme folder (26.0) by rmartinc · Pull Request #34187 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Change order of absolute path and normalize in the theme folder (26.0) - #34187

Merged
mposolda merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-34153-26.0
Oct 22, 2024
Merged

Change order of absolute path and normalize in the theme folder (26.0)#34187
mposolda merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-34153-26.0

Conversation

@rmartinc
@rmartinc rmartinc commented Oct 22, 2024
Copy link
Copy Markdown
Contributor

Closes #34028

PR: #34153
Commit: a84a2c2
PR branch: backport-34153-26.0
Target branch: https://github.com/keycloak/keycloak/tree/release/26.0

Backport for 26.0.

@rmartinc
Change order of absolute path and normalize in the theme folder (keyc…
5848aa3 
…loak#34153)

Closes keycloak#34028

Signed-off-by: rmartinc <rmartinc@redhat.com>
(cherry picked from commit a84a2c2)
@rmartinc
rmartinc requested a review from a team as a code owner October 22, 2024 09:03
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 22, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 22, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=130.0.6723.58)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

mposolda
mposolda approved these changes Oct 22, 2024
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc @jonkoops Thanks for the PR and review

@mposolda
mposolda merged commit d63d110 into keycloak:release/26.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmartinc @jonkoops @mposolda
0