8000 Only use cookie detection iframe for non-OIDC configurations (#34139) by jonkoops · Pull Request #34144 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Only use cookie detection iframe for non-OIDC configurations (#34139) - #34144

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-34139-26.0
Oct 21, 2024
Merged

Only use cookie detection iframe for non-OIDC configurations (#34139)#34144
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-34139-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 21, 2024
Copy link
Copy Markdown
Contributor

Closes #20287

Signed-off-by: Jon Koops jonkoops@gmail.com
(cherry picked from commit 43a59af)

@jonkoops
Only use cookie detection iframe for non-OIDC configurations (keycloa…
159e643 
…k#34139)

Closes keycloak#20287

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 43a59af)
@jonkoops
jonkoops requested a review from a team as a code owner October 21, 2024 11:47
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 21, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 21, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

org.keycloak.testsuite.forms.ResetOtpTest#removeOneSpecificOtpOnReset

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: COM01003: Internal error: Assertion failure: Expected boolean value to be false
	at org.wildfly.common.Assert.assertTrue(Assert.java:520)
	at org.keycloak.testsuite.forms.ResetOtpTest.removeOneSpecificOtpOnReset(ResetOtpTest.java:190)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
...

Report flaky test

@jonkoops
jonkoops merged commit 0c69e04 into keycloak:release/26.0 Oct 21, 2024
@jonkoops
jonkoops deleted the backport-34139-26.0 branch October 21, 2024 13:37
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edewit edewit edewit approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonkoops @edewit
0