8000 Clear all entries stored in local storage (#34056) by jonkoops · Pull Request #34088 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Clear all entries stored in local storage (#34056) - #34088

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-34056-26.0
Oct 18, 2024
Merged

Clear all entries stored in local storage (#34056)#34088
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-34056-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 18, 2024
Copy link
Copy Markdown
Contributor

Closes #15635

Signed-off-by: Jon Koops jonkoops@gmail.com
(cherry picked from commit 31ce14a)

@jonkoops
Clear all entries stored in local storage (keycloak#34056)
8000
5fbefa6 
Closes keycloak#15635

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 31ce14a)
@jonkoops
jonkoops requested a review from a team as a code owner October 18, 2024 10:33
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 18, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 18, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcSamlBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Base IT (2)

java.lang.AssertionError: Did not find the event of expected type USER_DISABLED_BY_TEMPORARY_LOCKOUT. Events present: [IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR]
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.AssertEvents$ExpectedEvent.assertEvent(AssertEvents.java:410)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:586)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=129.0.6668.89)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

@jonkoops
jonkoops merged commit 1190b32 into keycloak:release/26.0 Oct 18, 2024
@jonkoops
jonkoops deleted the backport-34056-26.0 branch October 18, 2024 13:06
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@agagancarczyk agagancarczyk agagancarczyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkoops @pedroigor @agagancarczyk
0