Repository navigation
Automatically retrieve configuration for authorization - #34044
Merged
Merged
Conversation
Closes keycloak#14562 Signed-off-by: Jon Koops <jonkoops@gmail.com>
pedroigor
approved these changes
Oct 17, 2024
Contributor
There was a problem hiding this comment.
LGTM.
I'm not sure how much this API is used. Perhaps we can also consider removing it.
Contributor
Author
Agreed. Long term we probably will. But in the meantime I want to get Keycloak JS fixed up to a point it is sort of maintainable. |
agagancarczyk
approved these changes
Oct 18, 2024
jonkoops
added a commit
to jonkoops/keycloak
that referenced
this pull request
Oct 18, 2024
Closes keycloak#14562 Signed-off-by: Jon Koops <jonkoops@gmail.com> (cherry picked from commit 7657e71)
This was referenced Oct 18, 2024
jonkoops
added a commit
that referenced
this pull request
Oct 29, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7F21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the JavaScript authorization client so that it retrieves its configuration lazily. Previously this would happen when a
KeycloakAuthorizationwas constructed, which triggered asynchronous side-effects that could create race conditions when calling methods on the instance.This change also means that the
readyproperty and.init()method (which was called at time of construction) are no longer relevant. These APIs are now essentially a "no-op" and have been deprecated and slated for removal in the next major.Closes #14562