8000 Fix broken JavaScript adapter tests when running in cross-origin context by jonkoops · Pull Request #34753 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Fix broken JavaScript adapter tests when running in cross-origin context - #34753

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-32654-26.0
Nov 7, 2024
Merged

Fix broken JavaScript adapter tests when running in cross-origin context#34753
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-32654-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Nov 7, 2024
Copy link
Copy Markdown
Contributor

Closes #23732

Signed-off-by: Jon Koops jonkoops@gmail.com
Signed-off-by: rmartinc rmartinc@redhat.com
Co-auhored-by: rmartinc rmartinc@redhat.com
(cherry picked from commit 82ad09b)

@jonkoops
Fix broken JavaScript adapter tests when running in cross-origin context
6b7177c 
Closes keycloak#23732

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: rmartinc <rmartinc@redhat.com>
Co-auhored-by: rmartinc <rmartinc@redhat.com>
(cherry picked from commit 82ad09b)
@jonkoops
jonkoops requested review from a team as code owners November 7, 2024 15:58
@jonkoops
jonkoops enabled auto-merge (squash) November 7, 2024 15:58
@jonkoops
jonkoops merged commit beb548a into keycloak:release/26.0 Nov 7, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Nov 7, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Nov 7, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.forms.ResetOtpTest#removeOneSpecificOtpOnReset

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: COM01003: Internal error: Assertion failure: Expected boolean value to be false
	at org.wildfly.common.Assert.assertTrue(Assert.java:520)
	at org.keycloak.testsuite.forms.ResetOtpTest.removeOneSpecificOtpOnReset(ResetOtpTest.java:190)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
...

Report flaky test

@jonkoops
jonkoops deleted the backport-32654-26.0 branch November 7, 2024 16:59
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonkoops @ahus1
0