8000 Fix Quarkus dev mode by vmuzikar · Pull Request #34550 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Fix Quarkus dev mode - #34550

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:fix-mvnpm
Nov 1, 2024
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:fix-mvnpm

Conversation

@vmuzikar
Copy link
Copy Markdown
Contributor

Closes #34549

@vmuzikar
Copy link
Copy Markdown
Contributor Author

Didn't found a good and reliable way to activate the profile automatically in dev env.

Alternative to this would be using quarkus.class-loading.removed-artifacts but the Maven way feels cleaner and more reliable. I reckon we might have more dev-only deps in the future (Dev UI services etc.).

@Pepo48
Pepo48 commented Oct 31, 2024
Copy link
Copy Markdown
Contributor

@vmuzikar just an idea - what about using the opportunity to add an IDE run configuration the way Quarkus does it?

I can think of two we also mention in our readme - Run Keycloak and Debug Keycloak.

@Pepo48 Pepo48 left a comment •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 8000 form class="js-timeline-comment-minimize d-md-inline-block d-flex" data-turbo="false" action="/keycloak/keycloak/pull/34550/reviews/2408906290/minimize" accept-charset="UTF-8" method="post">

I think we still need to address io.mvnpm.importmap dependency exclusion in quarkus/deployment/pom.xml.

With this exclusion in place the ../mvnw -f server/pom.xml compile quarkus:dev -Dquarkus.args="start-dev" -Pdev doesn't work.

Edit:
For the clarification, it works when the command is executed from the terminal. It doesn't work when the same command is executed as a maven run configuration from Intellij IDEA.

Closes keycloak#34549

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
@vmuzikar
vmuzikar commented Nov 1, 2024
Copy link
Copy Markdown
Contributor Author

@Pepo48 Thanks for the review! I took a different approach without the dev profile, and I believe it should be fine now. Let me know if that works for you.

@vmuzikar
vmuzikar requested a review from Pepo48 November 1, 2024 09:49
@Pepo48 Pepo48 left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me now. And I like this approach more. Thanks, @vmuzikar.

@vmuzikar
vmuzikar merged commit 9a7cfb3 into keycloak:main Nov 1, 2024
vmuzikar added a commit to vmuzikar/keycloak that referenced this pull request Nov 1, 2024
Closes keycloak#34549

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
(cherry picked from commit 9a7cfb3)
@vmuzikar
vmuzikar deleted the fix-mvnpm branch November 1, 2024 13:57
ahus1 pushed a commit that referenced this pull request Nov 1, 2024
Closes #34549

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
(cherry picked from commit 9a7cfb3)
@edewit edewit mentioned this pull request Nov 19, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quarkus dev mode does not work

2 participants

0