8000 Add validChecksum to jpa-changelog-26.0.0.xml by sguilhen · Pull Request #34521 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add validChecksum to jpa-changelog-26.0.0.xml - #34521

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:34450-mssql-hide-on-login
Oct 31, 2024
Merged

pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:34450-mssql-hide-on-login

Conversation

@sguilhen
Copy link
Copy Markdown
Contributor

Closes #34450

Closes keycloak#34450

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
@sguilhen
sguilhen requested a review from a team as a code owner October 30, 2024 19:19
@sguilhen
Copy link
Copy Markdown
Contributor Author

@rmartinc I've tested an upgrade from 26.0.0 and now it works fine, doesn't complain about the checksum

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.actions.TermsAndConditionsTest#termsDeclined

Keycloak CI - Base IT (1)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.actions.TermsAndConditionsTest.termsDeclined(TermsAndConditionsTest.java:170)
...

Report flaky test

@rmartinc rmartinc left a comment •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sguilhen!

@pedroigor
pedroigor merged commit 9c50813 into keycloak:main Oct 31, 2024
@sguilhen
sguilhen deleted the 34450-mssql-hide-on-login branch December 12, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[26.0.2] Migration from 25.0.1 Identity Provider Errors

3 participants

0