8000 Ensure organization id is preserved on export/import by sguilhen · Pull Request #33244 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Ensure organization id is preserved on export/import - #33244

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
sguilhen:33207-org-import-export
Sep 25, 2024
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
sguilhen:33207-org-import-export

Conversation

@sguilhen
Copy link
Copy Markdown
Contributor
  • Also fixes issues with description, enabled, and custom attributes missing when re-importing the orgs.

Closes #33207

@vramik vramik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thank you @sguilhen! It might be worth to also add a testcase, wdyt?

@vramik vramik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test will be added as a follow-up. Thanks

@sguilhen
Copy link
Copy Markdown
Contributor Author

@vramik sorry for the confusion, I ended up updating the tests in this PR

@sguilhen
sguilhen requested a review from vramik September 25, 2024 12:13
- Also fixes issues with description, enabled, and custom attributes missing when re-importing the orgs.

Closes keycloak#33207

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#changeAuthenticatorProperties

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=d3c7166d-19e3-4ee5-bf07-43f67c9df113&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessUserVerRegTest#preferredVerificationWrong

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=b47189e6-a8d5-467d-a8c0-85faac64e77c&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.BrowserButtonsTest#clickBackButtonFromRegisterPage

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=2ebffba3-841e-44e6-8351-3f962677cbbc&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @vramik's review

@ahus1
ahus1 merged commit 6424708 into keycloak:main Sep 25, 2024
@sguilhen
sguilhen deleted the 33207-org-import-export branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Organizations] Preserve org id in exported realms

3 participants

0