8000 more space for the title override PF style by edewit · Pull Request #33746 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

more space for the title override PF style - #33746

Merged
ssilvert merged 2 commits into
keycloak:mainfrom
edewit:issue-33607
Oct 23, 2024
Merged

ssilvert merged 2 commits into
keycloak:mainfrom
edewit:issue-33607

Conversation

@edewit
@edewit edewit commented Oct 9, 2024
Copy link
Copy Markdown
Contributor

Screenshot from 2024-10-09 15-41-08

fixes: #33607
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

fixes: keycloak#33607
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@benalbrecht
benalbrecht commented Oct 19, 2024 •
Copy link
Copy Markdown

this doesn't look good in french:

image

a safer approach might be to use separate rows?

@edewit
edewit commented Oct 22, 2024
Copy link
Copy Markdown
Contributor Author

@benalbrecht right, but we have to stick to the design

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@ssilvert
ssilvert merged commit d1504e4 into keycloak:main Oct 23, 2024
edewit added a commit to edewit/keycloak that referenced this pull request Oct 30, 2024
* more space for the title override PF style

fixes: keycloak#33607
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* changed to percentages

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit d1504e4)
agagancarczyk pushed a commit that referenced this pull request Oct 30, 2024
* more space for the title override PF style

fixes: #33607
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* changed to percentages

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit d1504e4)
@edewit edewit mentioned this pull request Nov 19, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix v2 login layout

3 participants

0