8000 Ensure `createRegisterUrl()` calls are `await`ed internally (#33650) by jonkoops · Pull Request #33655 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Ensure createRegisterUrl() calls are awaited internally (#33650) - #33655

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-33650-26.0
Oct 7, 2024
Merged

Ensure createRegisterUrl() calls are awaited internally (#33650)#33655
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-33650-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 7, 2024
Copy link
Copy Markdown
Contributor

Closes #33645

Signed-off-by: Jon Koops jonkoops@gmail.com
(cherry picked from commit c3a74fa)

@jonkoops
Ensure createRegisterUrl() calls are awaited internally (keycloak… 8000
816e80f 
…#33650)

Closes keycloak#33645

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit c3a74fa)
@jonkoops
jonkoops requested a review from a team as a code owner October 7, 2024 16:46
@jonkoops
jonkoops enabled auto-merge (squash) October 7, 2024 16:47
@jonkoops
jonkoops merged commit 3b22d90 into keycloak:release/26.0 Oct 7, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 7, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 7, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@jonkoops
jonkoops deleted the backport-33650-26.0 branch October 8, 2024 08:04
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmartinc rmartinc rmartinc approved these changes
+2 more reviewers
@keycloak-github-bo 6570 t keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@agagancarczyk agagancarczyk agagancarczyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkoops @agagancarczyk @rmartinc
0