8000 Add option to include the organization id in the organization claims by sguilhen · Pull Request #33495 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Add option to include the organization id in the organization claims - #33495

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:32746-add-orgid-tokens
Oct 3, 2024
Merged

Add option to include the organization id in the organization claims#33495
pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:32746-add-orgid-tokens

Conversation

@sguilhen
@sguilhen sguilhen commented Oct 2, 2024
Copy link
Copy Markdown
Contributor

Closes #32746

Maksim Zvankovich @sguilhen
Add option to include the organization id in the organization claims
f5f6932 
Closes keycloak#32746

Signed-off-by: Maksim Zvankovich <m.zvankovich@nexovagroup.eu>
Co-authored-by: Stefan Guilhen <sguilhen@redhat.com>
8000
@sguilhen
sguilhen requested review from a team as code owners October 2, 2024 18:27
@sguilhen sguilhen mentioned this pull request Oct 2, 2024
Closed
@pedroigor
pedroigor enabled auto-merge (rebase) October 2, 2024 19:03
This was referenced Oct 2, 2024
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 2, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 2, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcSamlBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - FIPS IT (non-strict)

java.lang.AssertionError: Did not find the event of expected type USER_DISABLED_BY_TEMPORARY_LOCKOUT. Events present: [IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR]
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.AssertEvents$ExpectedEvent.assertEvent(AssertEvents.java:403)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:586)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@pedroigor
pedroigor merged commit 35eba8b into keycloak:main Oct 3, 2024
@sguilhen
sguilhen deleted the 32746-add-orgid-tokens branch October 25, 2024 14:37
@bdovaz bdovaz mentioned this pull request Jun 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edewit edewit edewit approved these changes
@pedroigor pedroigor pedroigor approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add organization id to the organization claim of the access token

3 participants

@sguilhen @edewit @pedroigor
0