8000 fix: mark slf4j as not optional for the operator by shawkins · Pull Request #32652 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: mark slf4j as not optional for the operator - #32652

Merged
stianst merged 1 commit into
keycloak:release/24.0from
shawkins:iss32651
Sep 4, 2024
Merged

fix: mark slf4j as not optional for the operator#32652
stianst merged 1 commit into
keycloak:release/24.0from
shawkins:iss32651

Conversation

@shawkins
@shawkins shawkins commented Sep 4, 2024 •
edited by jonkoops
Loading
Copy link
Copy Markdown
Contributor

Closes #32651

@shawkins
fix: mark slf4j as not optional for the operator
279bca9 
closes: keycloak#32651

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested review from a team as code owners September 4, 2024 11:43
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 4, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Sep 4, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.example.cors.CorsExampleAdapterTest#angularCorsProductTest

Keycloak CI - Base IT

org.openqa.selenium.TimeoutException: 
timeout: Timed out receiving message from renderer: 10.000
  (Session info: chrome=128.0.6613.113)
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1442-579', ip: '10.1.0.138', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
...

Report flaky test

org.keycloak.testsuite.fo 8000 rms.ResetPasswordTest#resetPasswordLink

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1773-239', ip: '10.1.0.78', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserLoginTest#loginWithRevalidateCertEnabledCertIsTrusted

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@vmuzikar
vmuzikar enabled auto-merge (squash) September 4, 2024 13:35
@jonkoops jonkoops linked an issue Sep 4, 2024 that may be closed by this pull request
Mark slf4j-api as not optional for the 24 release #32651
Closed
@stianst
stianst disabled auto-merge September 4, 2024 14:13
@stianst
stianst merged commit 83f6f1f into keycloak:release/24.0 Sep 4, 2024
@shawkins shawkins mentioned this pull request Sep 26, 2024
Closed
vmuzikar pushed a commit to vmuzikar/keycloak that referenced this pull request Nov 6, 2024
@shawkins @vmuzikar
fix: mark slf4j as not optional for the operator (keycloak#32652)
e5fb612 
closes: keycloak#32651

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
stianst pushed a commit that referenced this pull request Nov 7, 2024
@vmuzikar @shawkins
fix: mark slf4j as not optional for the operator (#32652) (#34699)
e11e019 
closes: #32651

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Steven Hawkins <shawkins@redhat.com>
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark slf4j-api as not optional for the 24 release

3 participants

@shawkins @vmuzikar @stianst 3459
0