Repository navigation
Fix compilation error - #30416
Fix compilation error#30416
Conversation
|
Let's wait for the tests to run. |
ca3c538 to
f44c5b6
Compare
|
The Protostream pull request caused a conflict with #30381 and the main branch is not compiling anymore. I'm surprised the test suite didn't fail with #30381 because the events are cast to I've created new event 8000 s. Can @vramik @pedroigor review this PR, please? Thanks! |
|
@pruivo - I talked to @pedroigor and he would be ok to merge this now to fix the broken build and then discuss later. He'll be in contact with you. |
There was a problem hiding this comment.
One of the reasons we added this method is to allow register invalidations on the realm cache for whatever entry we want. Therefore, avoid having methods like those below that are specific to organizations.
For instance, other similar methods like registerGroup|role|etc do not make much sense if you can have a single method like that one. We are not changing this in other places but for orgs, we would like to avoid adding methods in this interface.
Can we keep the previous contract?
There was a problem hiding this comment.
Yes, I can add a "generic" event and keep the old contract 👍
Signed-off-by: Pedro Ruivo <pruivo@redhat.com>
f44c5b6 to
b36232a
Compare
|
Thanks @ahus1 @pedroigor. I've updated the PR. |
|
ps. didn't run the test suite locally, better wait for GHA report 👍 |
No description provided.