Repository navigation
Fix oid4vc mappers - #29806
Merged
Merged
Fix oid4vc mappers#29806
Conversation
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
wistefan
force-pushed
the
fix-oid4vc-mappers
branch
from
May 23, 2024 07:11
4c87bb8 to
c863197
Compare
wistefan
marked this pull request as ready for review
May 23, 2024 09:27
Contributor
|
@francis-pouatcha @tnorimat @pskopek Anyone of you available to review this please? |
Contributor
|
@mposolda Hello, I will review the PR. |
tnorimat
suggested changes
May 24, 2024
| @@ -335,6 +335,7 @@ public void testRequestCredentialUnsupportedCredential() throws Throwable { | |||
| @Test | |||
| public void testRequestCredential() { | |||
Contributor
There was a problem hiding this comment.
How about add these additional check in requestOffer ?
Contributor
There was a problem hiding this comment.
I confirmed the fix. Thank you.
Contributor
There was a problem hiding this comment.
I confirmed the fix. Thank you.
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
tnorimat
approved these changes
May 24, 2024
| @@ -335,6 +335,7 @@ public void testRequestCredentialUnsupportedCredential() throws Throwable { | |||
| @Test | |||
| public void testRequestCredential() { | |||
Contributor
There was a problem hiding this comment.
I confirmed the fix. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluates the supportedTypes of the OID4VC mapper config.
Fixes #29805