Repository navigation
feat(SAML): add Artifact Binding on brokering scenarios when Keycloak is SP - #29619
Merged
pedroigor merged 5 commits intoJun 14, 2024
Merged
Conversation
tmorin
force-pushed
the
feature/add-artifact-binding-when-sp
branch
4 times, most recently
from
May 22, 2024 06:34
4888eec to
dee0a34
Compare
tmorin
force-pushed
the
feature/add-artifact-binding-when-sp
branch
8 times, most recently
from
May 31, 2024 11:41
aa1f680 to
d826848
Compare
pedroigor
force-pushed
the
feature/add-artifact-binding-when-sp
branch
from
June 3, 2024 10:28
d826848 to
919ec34
Compare
pedroigor
enabled auto-merge (rebase)
June 13, 2024 10:32
pedroigor
disabled auto-merge
June 13, 2024 10:32
jonkoops
previously approved these changes
Jun 13, 2024
pedroigor
dismissed stale reviews from jonkoops, mposolda, and themself
via
June 13, 2024 12:28
92b6bd2
pedroigor
force-pushed
the
feature/add-artifact-binding-when-sp
branch
from
June 13, 2024 12:49
92b6bd2 to
8975c38
Compare
pedroigor
previously approved these changes
Jun 13, 2024
pedroigor
force-pushed
the
feature/add-artifact-binding-when-sp
branch
from
June 13, 2024 15:03
8975c38 to
fedfdf4
Compare
8000
Contributor
|
I had to fix the |
pedroigor
approved these changes
Jun 13, 2024
Signed-off-by: tmorin <git@morin.io>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
pedroigor
force-pushed
the
feature/add-artifact-binding-when-sp
branch
from
June 13, 2024 19:45
2abca03 to
889df1f
Compare
pedroigor
enabled auto-merge (rebase)
June 13, 2024 20:43
pedroigor
disabled auto-merge
June 13, 2024 20:45
jonkoops
approved these changes
Jun 14, 2024
Contributor
|
@tmorin Thanks for your time! Finally merged ... |
Contributor
Author
This was referenced Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the pull request is to support ARTIFACT-BINDING in a brokering scenario when Keycloak is the Service Provider.
The PR impacts the UI when creating/configuring an Identity Provider with the SAMLv2 protocol:
The PR impacts the discovery of the SAMLv2 metadata by retrieving the URL of the Artifact Resolver when available.
The PR impacts the SAML endpoint handling the SAML artifact as well as the resolution of the assertion using the Artifact Resolver URL.
The PR impacts the documentation by adding entries about the new fields.
Closes #14073
Closes #25745