8000 Add docs for transient-users how to prevent profile-review by Captain-P-Goldfish · Pull Request #28889 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add docs for transient-users how to prevent profile-review - #28889

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
Captain-P-Goldfish:transient-users-doc
Apr 18, 2024
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
Captain-P-Goldfish:transient-users-doc

Conversation

@Captain-P-Goldfish
Copy link
Copy Markdown
Contributor

#relatesTo #26637

@Captain-P-Goldfish
Captain-P-Goldfish requested a review from a team as a code owner April 18, 2024 11:36
@hmlnarik hmlnarik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look good. Could you please add the commit signature (for the DCO check)?

@hmlnarik
Copy link
Copy Markdown
Contributor

With #28874 merged, there is a conflict now, could you please rebase?

@ahus1 ahus1 self-assigned this Apr 18, 2024
@Captain-P-Goldfish
Copy link
Copy Markdown
Contributor Author

done.

@ahus1
ahus1 commented Apr 18, 2024
Copy link
Copy Markdown
Member

@Captain-P-Goldfish - thank you for resolving the conflicts. The checks are still read as the commit message misses the Sign-off line as outlined in CONTRIBUTING.md

Please update your commit with a signoff.

Signed-off-by: Captain-P-Goldfish <captain.p.goldfish@gmx.de>

#relatesTo keycloak#26637
@Captain-P-Goldfish
Captain-P-Goldfish commented Apr 18, 2024 •
Copy link
Copy Markdown
Contributor Author

sorry forgot the option. Updated the commit with the --signoff option

@ahus1
ahus1 merged commit ef45629 into keycloak:main Apr 18, 2024
@ahus1
ahus1 commented Apr 18, 2024
Copy link
Copy Markdown
Member

Thank you for taking the time to contribute this documentation enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0