Repository navigation
Added Client Type feature flag to begin client type work - #26389
Conversation
Passing run #10749 ↗︎
Details:
Review all test suite changes for PR #26389 ↗︎ |
|||||||||||||||
There was a problem hiding this comment.
Not sure about introducing a profile without a feature, but the code looks good to me.
|
@vickeybrown you'll have to sign off on your commits for the CI to pass. |
89092ce to
c0a8226
Compare
There was a problem hiding this comment.
Please update HelpCommandDistTest expected messages in https://github.com/keycloak/keycloak/tree/main/quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help. See eg. #23977 for an example of adding an experimental feature flag
|
@mposolda Since this feature belongs to @keycloak/core team, could you please review as well? |
There was a problem hiding this comment.
@vickeybrown Thanks! I am fine with introducing the experimental feature flag for client types as long as tests are OK.
@hmlnarik PR is assigned to you, so leaving to you to further review/merge whenever you are ok. I've re-triggered the tests (as I am not sure those are real failures or instability)
Closes keycloak#26346 Signed-off-by: vibrown <vibrown@redhat.com>
Signed-off-by: vibrown <vibrown@redhat.com>
Signed-off-by: vibrown <vibrown@redhat.com>
Signed-off-by: vibrown <vibrown@redhat.com>
ca26acd to
3ea26aa
Compare
) * Added Client Type feature flag to begin client type work Closes keycloak#26346 Signed-off-by: vibrown <vibrown@redhat.com> * Fixed formatting issue Signed-off-by: vibrown <vibrown@redhat.com> * Updated HelpCommandDistTest messages Signed-off-by: vibrown <vibrown@redhat.com> * Fixed formatting on HelpCommandDistTest messages Signed-off-by: vibrown <vibrown@redhat.com> --------- Signed-off-by: vibrown <vibrown@redhat.com> Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Closes #26346