Repository navigation
Brute Force Detection is disabled when updating frontenUrl via admin client - #26718
Conversation
…client Closes keycloak#21409 Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
There was a problem hiding this comment.
Is it possible to run UI tests with this change as well?
They are not executed automatically by GH actions on this PR due the fact that nothing is changed in the UI. But it is possible to test them by creating another branch with your changes, then doing some "dummy" change in the UI files (just to enforce UI build) and then push this new branch. Perhaps something like:
git checkout 21409
git checkout -b 21409-with-dummy-ui-change
// Change something in the UI files
git add -A
git commit -s -m "Commit of dmmy UI change"
git push origin 21409-with-dummy-ui-change
# Now see if UI tests are OK in your repo ...
For the possible "Dummy" change, which triggers UI tests - this one can be good to go for the inspiration: #26561 (comment) .
Separate branch is good just so that you don't need to push dummy change to the original PR .
Another note: There is also PR from Stian, which is a different fix, but maybe bit related: #26729 . Can be probably good to rebase your fix on top of that one. I guess it would be ready in main in next few hours, so likely when you're reading this, it is already in Keycloak main :-)
Passing run #10951 ↗︎
Details:
Review all test suite changes for PR #26718 ↗︎ |
|||||||||||||||
Closes #21409