8000 Supporting OAuth 2.1 for confidential clients by tnorimat · Pull Request #25318 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Supporting OAuth 2.1 for confidential clients - #25318

Merged
mposolda merged 1 commit into
keycloak:mainfrom
Hitachi:ISSUE-25314-OAuth-2-1-Confidential-Client
Feb 22, 2024
Merged

Supporting OAuth 2.1 for confidential clients#25318
mposolda merged 1 commit into
keycloak:mainfrom
Hitachi:ISSUE-25314-OAuth-2-1-Confidential-Client

Conversation

@tnorimat
@tnorimat tnorimat commented Dec 6, 2023
Copy link
Copy Markdown
Contributor

closes #25314

@ghost ghost added the flaky-test label Dec 6, 2023
This was referenced Dec 6, 2023
Closed
Closed
@mposolda
mposolda commented Dec 11, 2023
Copy link
Copy Markdown
Contributor

@tnorimat Looks good. So looks again that missing parts are tests and docs?

@mposolda mposolda self-assigned this Dec 11, 2023
@tnorimat
tnorimat commented Dec 12, 2023
Copy link
Copy Markdown
Contributor Author

@mposolda Yes, this PR lacks tests and docs. Therefore, I sent the PR as Draft-PR. I am now working on them.

Moreover, I investigated the OAuth 2.1 specification thoroughly and found that I need do to some work.
For example, adding a new executor for matching redirect_uri by considering IPv4/IPv6 loopback addresses and private-use URI schemes(custom URL schemes) for native-app clients.

@tnorimat
tnorimat force-pushed the ISSUE-25314-OAuth-2-1-Confidential-Client branch from 4a8700f to d43e79d Compare December 18, 2023 19:25
@tnorimat tnorimat closed this Feb 20, 2024
@tnorimat tnorimat reopened this Feb 20, 2024
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Feb 20, 2024
Closed
@tnorimat
tnorimat marked this pull request as ready for review February 21, 2024 09:05
@tnorimat
tnorimat requested review from a team as code owners February 21, 2024 09:05
@tnorimat
tnorimat force-pushed the ISSUE-25314-OAuth-2-1-Confidential-Client branch from d43e79d to f6394ce Compare February 21, 2024 09:05
mposolda
mposolda reviewed Feb 21, 2024
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat Thanks! Added minor comment regarding documentation.

Comment thread docs/documentation/securing_apps/topics/oidc/oauth21-support.adoc Resolved
@mposolda
mposolda requested a review from andymunro February 21, 2024 09:13
@mposolda
mposolda commented Feb 21, 2024
Copy link
Copy Markdown
Contributor

@andymunro Could you please review documentation part of this PR?

@tnorimat
tnorimat force-pushed the ISSUE-25314-OAuth-2-1-Confidential-Client branch 2 times, most recently from 245f1ec to cca4f19 Compare February 21, 2024 10:13
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Feb 21, 2024
Closed
@tnorimat @skabano
Supporting OAuth 2.1 for confidential clients
cc8be11 
closes keycloak#25314

Co-authored-by: shigeyuki kabano <shigeyuki.kabano.sj@hitachi.com>
Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
@tnorimat
tnorimat force-pushed the ISSUE-25314-OAuth-2-1-Confidential-Client branch from cca4f19 to cc8be11 Compare February 21, 2024 12:07
This was referenced Feb 21, 2024
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Feb 21, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Feb 21, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.UpdateEmailTest#updateEmailLinkNotVisibleWithoutUpdateEmailActionEnabled

Keycloak CI - Account Console IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"#username"}
  (Session info: chrome-headless-shell=121.0.6167.184)
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
...

Report flaky test

mposolda
mposolda approved these changes Feb 22, 2024
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat @andymunro Thanks for the review and all the updates to this PR!

@mposolda
mposolda merged commit 9ea679f into keycloak:main Feb 22, 2024
@tnorimat
tnorimat deleted the ISSUE-25314-OAuth-2-1-Confidential-Client branch February 22, 2024 08:10
@tnorimat tnorimat mentioned this pull request Mar 1, 2024
Closed
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@andymunro andymunro andymunro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting OAuth 2.1 for confidential clients

3 participants

@tnorimat @mposolda @andymunro
0