8000 Remove GlobalLockProviderSpi by mhajas · Pull Request #25206 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Remove GlobalLockProviderSpi - #25206

Merged
mhajas merged 1 commit into
keycloak:mainfrom
mhajas:24103-Map-Store-Removal-Delete-GlobalLockProvider
Dec 1, 2023
Merged

mhajas merged 1 commit into
keycloak:mainfrom
mhajas:24103-Map-Store-Removal-Delete-GlobalLockProvider

Conversation

@mhajas
@mhajas mhajas commented Dec 1, 2023
Copy link
Copy Markdown
Contributor

Closes #24103

This PR reverts changes done in this PR:
#14751

I wasn't sure whether to reintroduce dblock Quarkus option but then I decided not to as the option seemed to be introduced just for disabling db-lock provider in case when the map storage was used and since it is removed now we want to always enable db-lock and therefore we don't need any Quarkus option.

Closes keycloak#24103

Signed-off-by: Michal Hajas <mhajas@redhat.com>
@mhajas
mhajas requested a review from a team December 1, 2023 12:55
@mhajas
mhajas requested review from a team as code owners December 1, 2023 12:55
@sguilhen sguilhen left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhajas , LGTM!

@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @sguilhen's review.

@ghost ghost added the flaky-test label Dec 1, 2023
@mhajas
mhajas enabled auto-merge (squash) December 1, 2023 16:22
@mhajas
mhajas merged commit ec061e7 into keycloak:main Dec 1, 2023
@mhajas
mhajas deleted the 24103-Map-Store-Removal-Delete-GlobalLockProvider branch December 1, 2023 16:40
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Closes keycloak#24103

Signed-off-by: Michal Hajas <mhajas@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map Store Removal: Delete GlobalLockProvider

3 participants

0