8000 Escape ldap id when using normal attribute syntax (#25) by stianst · Pull Request #25037 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Escape ldap id when using normal attribute syntax (#25) - #25037

Closed
stianst wants to merge 1 commit into
keycloak:mainfrom
stianst:ldap
Closed

Escape ldap id when using normal attribute syntax (#25)#25037
stianst wants to merge 1 commit into
keycloak:mainfrom
stianst:ldap

Conversation

@stianst
@stianst stianst commented Nov 27, 2023
Copy link
Copy Markdown
Contributor

@stianst
stianst requested review from a team as code owners November 27, 2023 07:09
@stianst
stianst requested a review from a team November 27, 2023 07:09
@stianst
stianst requested a review from a team as a code owner November 27, 2023 07:09
This was referenced Nov 27, 2023
Closed
Closed
Closed
ahus1
ahus1 approved these changes Nov 27, 2023
View reviewed changes
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ahus1
ahus1 self-requested a review November 27, 2023 10:01
ahus1
ahus1 requested changes Nov 27, 2023
View reviewed changes
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there are two PRs, both pointing to main. With #25036 already being green, this one should go to to the KC23 branch?

@stianst stianst closed this Nov 27, 2023
@stianst
stianst deleted the ldap branch January 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 requested changes

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stianst @ahus1 @rmartinc
0