8000 Cleanup translations for DE/EN for a first test run of Weblate by ahus1 · Pull Request #25450 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Cleanup translations for DE/EN for a first test run of Weblate - #25450

Merged
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:translate
Dec 11, 2023
Merged

Cleanup translations for DE/EN for a first test run of Weblate#25450
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:translate

Conversation

@ahus1
@ahus1 ahus1 commented Dec 10, 2023
< 8000 span data-view-component="true"> Copy link
Copy Markdown
Member

Closes #25449

@ahus1
Cleanup translations for DE/EN for a first test run of Weblate
d7d6bcc 
Closes keycloak#25449

Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
@ahus1
ahus1 commented Dec 10, 2023 •
edited
Loading
Copy link
Copy Markdown
Member Author

@jonkoops - created this PR to clean up the translation files. Please review when you have the time.

@ahus1
ahus1 requested a review from jonkoops December 10, 2023 13:29
@ahus1
ahus1 marked this pull request as ready for review December 10, 2023 13:29
@ahus1
ahus1 requested review from a team as code owners December 10, 2023 13:29
@ghost ghost added team/ui labels Dec 10, 2023
@cypress
cypress Bot commented Dec 10, 2023 •
edited
Loading
Copy link
Copy Markdown

2 flaky tests on run #10190 ↗︎

0 545 54 0 Flakiness 2

Details:

Merge d7d6bcc into 0a95159...
Project: Keycloak Admin UI Commit: 052ca32713 ℹ️
Status: Passed Duration: 34:16 💡
Started: Dec 11, 2023 7:38 AM Ended: Dec 11, 2023 8:13 AM
Flakiness  cypress/e2e/clients_test.spec.ts • 2 flaky tests • chrome

View Output

Test Artifacts
Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name Test Replay Screenshots
Clients test > Mapping tab > Add mapping to openid client Test Replay Screenshots

Review all test suite changes for PR #25450 ↗︎

@ghost ghost added the flaky-test label Dec 10, 2023
@ghost ghost mentioned this pull request Dec 10, 2023
Closed
@ahus1
ahus1 commented Dec 11, 2023
Copy link
Copy Markdown
Member Author

@mhajas - please approve this PR based on @jonkoops' review and merge it. Thanks!

This would then enable us to go the next step with Weblate.

mhajas
mhajas approved these changes Dec 11, 2023
View reviewed changes
@mhajas mhajas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the review from @jonkoops. Thank you both!

@mhajas
mhajas merged commit 9672291 into keycloak:main Dec 11, 2023
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
@ahus1 @ShefeeqPM
Cleanup translations for DE/EN for a first test run of Weblate (keycl…
4c4cc05 
…oak#25450)

Closes keycloak#25449

Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jonkoops jonkoops jonkoops approved these changes
@mhajas mhajas mhajas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up translations for DE/EN/NL for a first test-run of Weblate

3 participants

@ahus1 @jonkoops @mhajas
0