8000 Adapter tests failing with Jakarta error by mabartos · Pull Request #24177 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Adapter tests failing with Jakarta error - #24177

Merged
mhajas merged 1 commit into
keycloak:mainfrom
mabartos:fix_sb_tests
Oct 24, 2023
Merged

mhajas merged 1 commit into
keycloak:mainfrom
mabartos:fix_sb_tests

Conversation

@mabartos
Copy link
Copy Markdown
Member

Fixes #24176

I was able to reproduce it, and with this fix, the Spring Boot instance is properly started. The reason behind these changes is that we use the JavaEE version of Undertow for the Keycloak Undertow adapter, but in the testsuite, we use the JakartaEE version of Undertow to be able to run tests on auth-server-undertow.

There was only a clash between the used version for the Spring Boot test app as we need to use the JavaEE Undertow dependency because of the Keycloak adapter.

I verify there's no other place we need to override it.

@Aboullos @miquelsi Could you please check it?

@mabartos
mabartos requested review from a team as code owners October 20, 2023 10:01
@mabartos
mabartos requested a review from a team October 20, 2023 10:01
@mabartos
mabartos requested a review from a team as a code owner October 20, 2023 10:01
@mabartos
mabartos requested review from Aboullos and miquelsi October 20, 2023 10:02
@Aboullos Aboullos left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mabartos
Copy link
Copy Markdown
Member Author

Rebased

@ghost ghost left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
ghost commented Oct 24, 2023
Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@mabartos
mabartos commented Oct 24, 2023 •
Copy link
Copy Markdown
Member Author

@Aboullos @miquelsi CI passed. I think this PR is ready to go. WDYT?

@Aboullos You executed the Spring Boot test on your local machine or in the pipeline to verify the proper behavior, right?

@Aboullos
Copy link
Copy Markdown
Contributor

@mabartos yes, I already execute them

@miquelsi
Copy link
Copy Markdown
Contributor

This should be backported to release/22 brach too. Please @mabartos or @Aboullos create a PR there too.

@mabartos
Copy link
Copy Markdown
Member Author

@miquelsi Backport for the 22.x release: #24180

@mhajas mhajas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mabartos

@mhajas
mhajas merged commit 9627187 into keycloak:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapter tests failing with Jakarta error

4 participants

0