Repository navigation
Conversation
* added necessary double quotes to kc.bat Closes keycloak#23563 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
Author
|
I realized that there is a long open PR #20212 from @jsorah that fixes the same and closes #20115. Joshua went a bit further with proposed changes, on the contrary, I provided the bare minimum to fix #23563 issue. The reason is that some time ago @sschu did a cleanup, so I don't want to accidentally re-introduce anything that the original cleanup fixed. Regardless, I'm fine with the Joshua's PR, I reviewed it multiple times and we were just waiting for a final confirmation from QE. If there are no objections, I'm totally fine with merging his PR in favour of mine. 😊 |
Contributor
Contributor
|
Superseded by #20212. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23563