Repository navigation
Fix lowerCaseHostname to lower-case scheme and host properly - #24819
Merged
Merged
Conversation
Closes keycloak#24792 Signed-off-by: rmartinc <rmartinc@redhat.com>
rmartinc
force-pushed
the
issue-24792
branch
from
November 17, 2023 11:15
d94aa00 to
7717441
Compare
This was referenced Nov 17, 2023
Closed
mposolda
approved these changes
Nov 20, 2023
Contributor
|
We believe that this PR solve the bug in a wrong way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24792
The
lowerCaseHostnamepreviously was assuming that the scheme washttp(starting at 7 until next char/). That created issues with other custom schemes and does not lower the the host in case ofhttps. The PR usesKeycloakUriBuilderto perform the lower in the passed redirect URI to verify and in the valid redirect URIs defined (scheme and host which are the parts are case-insensitive by spec). This way I think we are covering al the cases that are working now. I have added several unit tests to check this is working. CI passes OK.