8000 Do not run value transformation if a option is being requested by its name and there is no dependency on other options by pedroigor · Pull Request #24812 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Do not run value transformation if a option is being requested by its name and there is no dependency on other options - #24812

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-24757
Nov 21, 2023
Merged

pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-24757

Conversation

@pedroigor
Copy link
Copy Markdown
Contributor

Closes #24757

… name and there is no dependency on other options

Closes keycloak#24757

Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroigor Thanks, LGTM.

@shawkins Do you want to give it a final look too?

@vmuzikar
vmuzikar requested a review from shawkins November 21, 2023 10:47
@pedroigor
pedroigor merged commit 4c8724e into keycloak:main Nov 21, 2023
@pedroigor
pedroigor commented Nov 21, 2023 •
Copy link
Copy Markdown
Contributor Author

@vmuzikar @shawkins Deep sorries ... I went to quick and didn't see the comment from Vasek asking for Steven review.

I can either revert or do follow-ups depending on @shawkins feedback. Sorry.

@shawkins
Copy link
Copy Markdown
Contributor

@pedroigor no additional concerns from me. Thank you for untying this knot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefaultHostnameProvider reports being proxied when it is not

3 participants

0