Repository navigation
'Not username' and 'Not email' options when creating/changing a password, should ignore letter case when comparing password to email or to username - #22804
Merged
Conversation
Contributor
|
@pedro-hos sorry for this one taking so long, it shouldn't have as it's a simple change. Could you rebase it and we'll get this one reviewed/merged? |
Contributor
Author
|
@stianst I just noticed that the |
Contributor
|
Hi @pedro-hos! Sorry for not checking this for such a long time. Are you still interested in doing this? Can you rebase your branch and add the signature to the commit ( |
pedro-hos
force-pushed
the
issue-20649
branch
5 times, most recently
from
May 11, 2026 19:52
98ee2e6 to
104e1d7
Compare
…ord, should ignore letter case when comparing password to email or to username Signed-off-by: Pedro Henrique Silva <pesilva@redhat.com>
Contributor
Author
|
Thank you for your inputs @rmartinc can you please review this PR? |
rmartinc
approved these changes
May 13, 2026
Contributor
There was a problem hiding this comment.
Thanks @pedro-hos! I see that this was already fixed by Marek in #37431. But the test are OK. So I'm going to add it. Thanks!
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ord, should ignore letter case when comparing password to email or to username (keycloak#22804) Signed-off-by: Pedro Henrique Silva <pesilva@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20649
Hi @mposolda Idk if this issue is still valid, but I've finished the fix with two test cases, for not Email and not username. Let me know if I need to make some changes.
Thank you =D