8000
|
Tests are green. There is now a warning when re-augmentating Keycloak independent of the database being chosen:
After #22443, this warning is only shown when the Oracle Database is selected - even when |
|
@mabartos - in this PR we want to skip distributing the Oracle JDBC driver as part of Keycloak. Rebasing this PR on top of your PR #22443 removes the warning in all cases except when using the Oracle driver. When the Oracle driver is chosen, it still prints:
Do you know a way to avoid this warning? All tests are green. cc: @vmuzikar, @pedroigor |
@ahus1 If the Oracle DB is not selected, all the Oracle stuff is ignored. Ignored in terms of all related artifacts are not loaded by class loader and shouldn't be packed in the distribution at all. This warning is probably shown there because the Quarkus Oracle extension is still present and the related build steps still see it available and handle it in some way.
@vmuzikar Yep, that's the plan; we don't want to backport that stuff. |
|
@mabartos I think we might need to remove the whole extension and write instructions how to re-add it manually. |
|
AFAIK, the problem is on the Quarkus side. I'll create an issue and send a PR for the Oracle JDBC extension. I've experimented with the fix, and I don't see the warning anymore. |
|
@mabartos Thanks for investigating! Not sure how's that an issue on Quarkus side if we're removing a direct dependency of the extension. :) But let's see... In any case, if there's a fix on Quarkus side, we'd need to make sure it gets backported to 3.2 which might be too late to do. |
IMO, I'd like to avoid removing the Oracle JDBC Quarkus extension. We'd simplify the whole process around connecting to the Oracle DB as customers do not have to add the extension itself + the JDBC driver. We'll save time for them and even for us when writing documentation for that. There should not be any problem with the productization of the Quarkus Oracle JDBC extension, right? :)
Yep, I understand your concerns. These warnings should be related only to the native images. I'd suggest ignoring the warnings from the |
|
@mabartos Decreasing the log level works for me. |
3b77b6e to
d862810
Compare
|
Related Quarkus issue: quarkusio/quarkus#35402 |
|
@vmuzikar / @mabartos - I've updated the PR and the warning has been suppressed. I also added some docs. Please have a look. When backporting this for KC22, the docs would need to be tuned so they show up only for RHBK, and Keycloak 22 upstream still builds it. I saw that there is a very long error message message when the driver is not available with lots of |
There was a problem hiding this comment.
@ahus1 LGTM, thank you.
@mabartos Do you want to review as well?
I saw that there is a very long error message message when the driver is not available with lots of
io.quarkus.runtime.configuration.ConfigurationExceptionandjava.lang.ClassNotFoundException: oracle.jdbc.xa.client.OracleXADataSourceduring the build command. I want to handle this as a follow-up pull request if you agree. Ideally it would still make it for a KC22 backport.
+1
But I see it just as a non-blocking UX enhancement. We could perhaps even prohibit the db=oracle value (incl. help command) if the driver is not found on the classpath.
|
@vmuzikar Yes, I'd like to review it. Did you follow these steps for the docker image? Can you confirm everything works as expected? |
There was a problem hiding this comment.
Based on #22452 (comment), I discussed this a bit more with @stianst. Seems we should take a little bit different approach here.
main branch
includeProprietaryDependencies profile.providers directory instead of building KC with the driver included.Backport to 22
-DskipProprietary property to remove the driver. This would be used only by RHBK 22 pipelines. (CC @ASzc)@mabartos Would you be please able to take over as @ahus1 is on PTO?
Closes #22452