8000 Fixed a11y violations for clients by agagancarczyk · Pull Request #21310 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Fixed a11y violations for clients #21310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssilvert merged 5 commits into from
Jul 11, 2023
Merged

Fixed a11y violations for clients #21310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
420497c
fixed a11y violations for clients
agagancarczyk Jun 29, 2023
69739b5
Merge branch 'main' of https://github.com/keycloak/keycloak into issu…
agagancarczyk Jun 29, 2023
5e52ccf
feedback
agagancarczyk Jun 29, 2023
92591ff
Merge branch 'main' of https://github.com/keycloak/keycloak into issu…
agagancarczyk Jun 29, 2023
e6f7e44
Merge branch 'main' into issue-17711
agagancarczyk Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/apps/admin-ui/src/clients/authorization/PermissionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export default function PermissionDetails() {
{applyToResourceTypeFlag ? (
<FormGroup
label={t("resourceType")}
fieldId="name"
fieldId="resourceType"
labelIcon={
<HelpItem
helpText={t("clients-help:resourceType")}
Expand Down
4 changes: 2 additions & 2 deletions js/apps/admin-ui/src/clients/authorization/Permissions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,12 @@ export const AuthorizationPermissions = ({ clientId }: PermissionsProps) => {
<TableComposable aria-label={t("resources")} variant="compact">
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("common:name")}</Th>
<Th>{t("common:type")}</Th>
<Th>{t("associatedPolicy")}</Th>
<Th>{t("common:description")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
{permissions.map((permission, rowIndex) => (
Expand Down
6 changes: 3 additions & 3 deletions js/apps/admin-ui/src/clients/authorization/Resources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,14 @@ export const AuthorizationResources = ({ clientId }: ResourcesProps) => {
<TableComposable aria-label={t("resources")} variant="compact">
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("common:name")}</Th>
<Th>{t("displ 8000 ayName")}</Th>
<Th>{t("common:type")}</Th>
<Th>{t("owner")}</Th>
<Th>{t("uris")}</Th>
<Th />
<Th />
<Th aria-hidden="true" />
<Th aria-hidden="true" />
</Tr>
</Thead>
{resources.map((resource, rowIndex) => (
Expand Down
6 changes: 3 additions & 3 deletions js/apps/admin-ui/src/clients/authorization/Scopes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,11 @@ export const AuthorizationScopes = ({ clientId }: ScopesProps) => {
<TableComposable aria-label={t("scopes")} variant="compact">
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("common:name")}</Th>
<Th>{t("displayName")}</Th>
<Th />
<Th />
<Th aria-hidden="true" />
<Th aria-hidden="true" />
</Tr>
</Thead>
{scopes.map((scope, rowIndex) => (
Expand Down
0