Repository navigation
Remove unused feature flags. - #21039
Merged
Merged
Conversation
Passing run #7627 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
jonkoops
reviewed
Jun 16, 2023
| isViewGroupsEnabled = viewGrouRole != null && user.hasRole(viewGrouRole); | ||
| } | ||
|
|
||
| map.put("isTotpConfigured", isTotpConfigured); |
Contributor
There was a problem hiding this comment.
We might not be using these, but the community might. Perhaps we should add a release note?
Contributor
Author
There was a problem hiding this comment.
TOTP setup is now done via AIA for extra security. And we use a REST endpoint to determine which 2FA's are set. So the account console would never need this flag. If someone in the community is using it, they are doing it wrong.
That being said, something in the release notes doesn't hurt.
jonkoops
previously approved these changes
Jun 16, 2023
jonkoops
suggested changes
Jun 19, 2023
Co-authored-by: Jon Koops <jonkoops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20944
Fixes #20943
We have two feature flags in account console that apparently aren't being used any more. So I want to see if this breaks anything. Then maybe we will decide merge.