8000 GH Actions -> archive surefire reports (#21913). by lhanusov · Pull Request #21915 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

GH Actions -> archive surefire reports (#21913). - #21915

Merged
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:lhanusov/main/21913
Aug 31, 2023
Merged

GH Actions -> archive surefire reports (#21913).#21915
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:lhanusov/main/21913

Conversation

@lhanusov
@lhanusov lhanusov commented Jul 24, 2023
Copy link
Copy Markdown
Contributor

Closes #21913

@lhanusov
lhanusov requested a review from a team as a code owner July 24, 2023 14:53
@lhanusov
lhanusov requested review from miquelsi and stianst July 24, 2023 14:54
@lhanusov lhanusov self-assigned this Jul 24, 2023
@lhanusov lhanusov added this to the 22.0.2 milestone Jul 24, 2023
@lhanusov lhanusov added area/testsuite Test suites — flaky/failing tests, CI test config, test migration team/continuous-testing labels Jul 24, 2023
@lhanusov lhanusov mentioned this pull request Jul 24, 2023
Closed
@cypress
cypress Bot commented Jul 24, 2023 •
edited
Loading
Copy link
Copy Markdown

1 flaky test on run #8752 ↗︎

0 527 48 0 Flakiness 1

Details:

Merge 790aa9f into 4cd34f8...
Project: Keycloak Admin UI Commit: cac6ddfaf0 ℹ️
Status: Passed Duration: 50:13 💡
Started: Aug 31, 2023 10:16 AM Ended: Aug 31, 2023 11:06 AM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Test Replay Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ghost ghost added the flaky-test label Jul 24, 2023
This was referenced Jul 24, 2023
Closed
Closed
Closed
@lhanusov
lhanusov force-pushed the lhanusov/main/21913 branch 10 times, most recently from f8004b0 to 68c1413 Compare July 26, 2023 08:54
stianst
stianst reviewed Jul 26, 2023
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved
stianst
stianst reviewed Jul 26, 2023
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved
stianst
stianst reviewed Jul 26, 2023
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved
@lhanusov
lhanusov force-pushed the lhanusov/main/21913 branch 2 times, most recently from 459aa73 to ffc8d00 Compare August 1, 2023 13:29
@lhanusov
lhanusov force-pushed the lhanusov/main/21913 branch from ffc8d00 to 4b5a17f Compare August 2, 2023 11:12
@lhanusov
lhanusov commented Aug 2, 2023
Copy link
Copy Markdown
Contributor Author

@stianst all comments addressed, condition fixed, @miquelsi can you also review it? thanks

@ghost ghost mentioned this pull request Aug 28, 2023
Closed
ghost
ghost reviewed Aug 28, 2023
View reviewed changes
@ghost ghost left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
ghost commented Aug 28, 2023
Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterWithUserProfileTest#testRegisterUserSuccess_attributeNotRequiredAndSelectedByScopeCanBeSet

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...

Report flaky test

@lhanusov
lhanusov force-pushed the lhanusov/main/21913 branch 8 times, most recently from b545ed4 to faf05ef Compare August 29, 2023 14:46
@lhanusov
lhanusov force-pushed the lhanusov/main/21913 branch from faf05ef to 790aa9f Compare August 30, 2023 10:56
@stianst
stianst enabled auto-merge (squash) August 30, 2023 11:18
ghost
ghost reviewed Aug 30, 2023
View reviewed changes
@ghost ghost left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
ghost commented Aug 30, 2023
Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.MyResourcesTest#shouldAllowRequestToShare

Keycloak CI - Account Console IT (firefox)

org.openqa.selenium.UnhandledAlertException: 
Dismissed user prompt dialog: failed to initialize keycloak: 
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az344-249', ip: '10.1.0.69', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1041-azure', java.version: '17.0.8'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

This was referenced Aug 31, 2023
Closed
Closed
@stianst
stianst merged commit 2870ecf into keycloak:main Aug 31, 2023
lhanusov added a commit to lhanusov/keycloak that referenced this pull request Aug 31, 2023
@lhanusov
GH Actions -> archive surefire reports (keycloak#21913). (keycloak#21915
e65a940 
)
stianst pushed a commit that referenced this pull request Aug 31, 2023
@lhanusov
GH Actions -> archive surefire reports (#21913). (#21915) (#22858)
f470b32
This was referenced Sep 4, 2023
Closed
Closed
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes
+2 more reviewers
@miquelsi miquelsi miquelsi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lhanusov lhanusov

Labels

area/testsuite Test suites — flaky/failing tests, CI test config, test migration flaky-test

Projects

None yet

Milestone

22.0.2

Development

Successfully merging this pull request may close these issues.

GH Actions - Surefire reports artifact upload

3 participants

@lhanusov @miquelsi @stianst
0