Repository navigation
Convert LinkExpirationFormatterMethod to Java's ChoiceFormat pattern - #21888
Merged
hmlnarik merged 1 commit intoJul 27, 2023
Merged
Conversation
This was referenced Jul 22, 2023
Member
Author
|
@hmlnarik - as we've talked about translation formats recently, I wonder if you could review and merge this PR as well. I wasn't sure where to put the code for the conversion, so I placed it in a test case as it can be run interactively from the IDE. I could also remove it from there and paste it into this PR. WDYT? Thanks! |
stianst
reviewed
Jul 26, 2023
stianst
reviewed
Jul 26, 2023
ahus1
force-pushed
the
is-21887-fix-translations-for-language-counts
branch
from
July 26, 2023 09:05
1864aff to
8de973d
Compare
Member
Author
|
@stianst - this is now re 8000 ady for another review. Thanks! |
stianst
reviewed
Jul 26, 2023
ahus1
force-pushed
the
is-21887-fix-translations-for-language-counts
branch
from
July 26, 2023 09:18
8de973d to
1838920
Compare
stianst
previously approved these changes
Jul 26, 2023
stianst
enabled auto-merge (squash)
July 26, 2023 09:53
hmlnarik
disabled auto-merge
July 26, 2023 11:43
hmlnarik
suggested changes
Jul 26, 2023
Contributor
There was a problem hiding this comment.
I like this PR, this simplifies the automatic translation. Thank you.
However, four locales (ar, cz, sk, pl) lose their translations. Could you please fix?
ahus1
force-pushed
the
is-21887-fix-translations-for-language-counts
branch
from
July 26, 2023 13:12
1838920 to
e600a6a
Compare
hmlnarik
approved these changes
Jul 27, 2023
Contributor
8000
There was a problem hiding this comment.
Thanks for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21887
The code that was used to convert the different languages (except English) is present in
LinkExpirationFormatterMethodTest#convert.To test the result, consider for example
jshell:Discussion: #9270