8000 OTP support for binary secrets encoded in Base32 by rhyamada · Pull Request #20755 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

OTP support for binary secrets encoded in Base32 - #20755

Closed
rhyamada wants to merge 0 commit into
keycloak:mainfrom
rhyamada:main
Closed

OTP support for binary secrets encoded in Base32#20755
rhyamada wants to merge 0 commit into
keycloak:mainfrom
rhyamada:main

Conversation

@rhyamada
@rhyamada rhyamada commented Jun 2, 2023
Copy link
Copy Markdown
Contributor

This PR address issues #9434 and #11561

After this PR binary or external otp secrets can be imported Base32 encoded in database or thought api.

@rhyamada
rhyamada requested a review from a team as a code owner June 2, 2023 17:23
@ghost ghost added the flaky-test label Jun 2, 2023
ghost
ghost reviewed Jun 2, 2023
View reviewed changes
@ghost ghost left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
ghost commented Jun 2, 2023
Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.authentication.FlowTest#testAddRemoveFlow

Keycloak CI - Legacy Store IT (mysql)

java.lang.AssertionError: deleteFlow should fail for built in flow
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.admin.authentication.FlowTest.testAddRemoveFlow(FlowTest.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
...

Report flaky test

@rhyamada rhyamada closed this Jun 5, 2023
@rhyamada
rhyamada force-pushed the main branch 2 times, most recently from fd00124 to 81aa588 Compare June 5, 2023 17:11
@rhyamada rhyamada mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rhyamada
0