Repository navigation
Fix Base Testsuite timeouts on Windows - #19744
Conversation
c9c8d7b to
28b9614
Compare
|
@vplemyannik could you review this? We found out that the issue you reported was actually caused by the recent changes in the kc.bat script and not by the Ant's configure.xml. Due to the change in configure.xml some of the tests in our internal pipeline timed out. Therefore, we reverted the commit and provided the alternative fix. The problem was actually difficult to spot, since it happens only when there's a space in a path to a java binary (which is not the case in our internal pipelines, thus we missed it). Thanks for reporting this initially! |
cad931c to
91ac706
Compare
91ac706 to
9495740
Compare
|
Hi @sschu, this PR also touches some of the changes that were done as a part of #16229. I tried my best to enquote just the parts that are really necessary (one of the use cases is explained in the description above) in order to prevent a reintroduction of the issues that you solved earlier. Could you, please, take a look? Thanks. |
9495740 to
92b3c82
Compare
|
LGTM. |
92b3c82 to
fd65d02
Compare
…illian-servers-auth-server-quarkus module on Windows" This reverts commit ca9c6dd.
* edited kc.bat to prevent 'C:\Program' is not recognized as a command error (Ant BuildException) * fixed the internal pipeline build errors Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
fd65d02 to
0834818
Compare
Signed-off-by: Peter Zaoral pzaoral@redhat.com
The timeout issue was caused by the recent cleanup of kc.bat (#16229), where the majority of the double quote encapsulation was removed. This typically may cause a problem, when there is a space in a path of a binary (in this case java.exe). Therefore, at least
%JAVA%variable should stay enquoted (the binary is by default placed into Program Files, so the path may contain a space).I also used this PR as an opportunity to get rid of a warning about the usage of the unix file separators.