8000 16319 added quotes for start script config parameters by sschu · Pull Request #16339 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

16319 added quotes for start script config parameters - #16339

Closed
sschu wants to merge 1 commit into
keycloak:mainfrom
bosch-io:16319_fix_parameter_quoting_in_kc_bash_start_script
Closed

16319 added quotes for start script config parameters#16339
sschu wants to merge 1 commit into
keycloak:mainfrom
bosch-io:16319_fix_parameter_quoting_in_kc_bash_start_script

Conversation

@sschu
@sschu sschu commented Jan 9, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

Fixes #16319 for kc.sh.

This was referenced Jan 9, 2023
Closed
Merged
@sschu
sschu commented Jan 10, 2023
Copy link
Copy Markdown
Contributor Author

The test failures are a bit strange. The operator CI failures are most likely unrelated. The Quarkus IT might be related, however they run fine locally.

@mabartos
mabartos commented Mar 8, 2023
Copy link
Copy Markdown
Member

@sschu Could you please rebase and possibly add some tests for this? Thanks

@sschu
sschu force-pushed the 16319_fix_parameter_quoting_in_kc_bash_start_script branch from f98d5e1 to 52644f5 Compare March 21, 2023 17:26
@sschu
sschu requested review from a team as code owners March 21, 2023 17:26
@sschu
sschu commented Mar 21, 2023
Copy link
Copy Markdown
Contributor Author

@mabartos Sorry for taking some time on this. I realised the issue #16319 incorrectly missed the "=" between key and value so I adapted my PR to just add quotes and not handle the case of passing parameters without "=". I also added a tests which does check for the specific error message that appear on current master not appearing after my change. Is that fine for you? It's a bit brittle should that message change in the future. Alternatively, we could also add a jks file with blanks in the name and check for a successful startup without any errors. Or do you know any other non-file config option that takes an arbitrary string as parameter with blanks?

@cypress
cypress Bot commented Mar 21, 2023 •
edited
Loading
Copy link
Copy Markdown

5 flaky tests on run #6362 ↗︎

0 443 38 0 Flakiness 5

Details:

16319 added quotes for start script config parameters
Project: Keycloak Admin UI Commit: 11b2cc2dd0
Status: Passed Duration: 14:04 💡
Started: Mar 22, 2023 3:15 PM Ended: Mar 22, 2023 3:29 PM
Flakiness  clients_test.spec.ts • 4 flaky tests

View Output Video

Test Artifacts
Clients test > Client creation > Should cancel creating client Output Screenshots
Clients test 8000 > Client creation > Should fail creating client Output Screenshots
Clients test > Roles tab test > Should fail to create client role with empty name Output Screenshots
Clients test > Realm client > Hides the delete action Output Screenshots
Flakiness  realm_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Realm tests > should fail creating Master realm Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sschu
sschu force-pushed the 16319_fix_parameter_quoting_in_kc_bash_start_script branch from 52644f5 to 11b2cc2 Compare March 22, 2023 15:02
@sschu
sschu commented Mar 23, 2023
Copy link
Copy Markdown
Contributor Author

There are quite some test failures but I don't think they are related.

@ahus1
ahus1 commented Jul 6, 2023
Copy link
Copy Markdown
Member

With #16229 being merged and the original issue being closed, I assume this PR is obsolete. Please comment here if this is not the case, and I'll reopen this PR.

@ahus1 ahus1 closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keycloak have space in path , or keystore , truststore , or till js-provider if space it's failed

3 participants

@sschu @mabartos @ahus1
0