Repository navigation
File store basis - #16001
File store basis#16001hmlnarik merged 18 commits into
Conversation
9c9dc8c to
b2c1ce9
Compare
b2c1ce9 to
86008bd
Compare
59a236e to
f1c613b
Compare
89604fb to
e0ec287
Compare
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
46a9066 to
ee843c9
Compare
ee843c9 to
7bb41ba
Compare
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
8c5c410 to
6055376
Compare
|
Rebased due to conflict in pom.xml |
|
When I start Keycloak (keycloak-server from testsuite) and log in as an admin, then log out, log in again and so on, I see that user session are not being removed. I see multiple user session yaml files and also multiple active sessions under "sessions" tab in admin console. Is this expected? |
Co-authored-By: vramik <vramik@redhat.com>
6055376 to
a28b739
Compare
@martin-kanis Thank you, this has been fixed in the last commit (b47cbe8). |
| } | ||
|
|
||
| public void touch(Path path) throws FileAlreadyExistsException, IOException { | ||
| Files.createFile(path); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| "map": { | ||
| "storage-admin-events": { | ||
| "provider": "${keycloak.adminEventsStore.map.storage.provider:concurrenthashmap}" | ||
| "provider": "${keycloak.adminEventsStore.map.storage.provider,keycloak.mapStorage.provider.default:concurrenthashmap}" |
There was a problem hiding this comment.
Should this changes go into testsuite/integration-arquillian/tests/base/src/test/resources/META-INF/keycloak-server.json as well?
There was a problem hiding this comment.
In the arquillian testsuite, there are map-storage-* profiles which define all the necessary properties for map storage. Here it is only for convenience usage from CLI. So while I agree it would be nice, I consider this a follow-up task if the need arises.
There was a problem hiding this comment.
@hmlnarik Thank you for the huge amount of work!
This PR introduces file store basis. It includes generic file store based on YAML in a directory structure, and Keycloak is able to run with file store for almost all areas, see Q&A. The limitations are:
SingleUseObjectProvideris a global store, has no realm parameter, and thus does not fit into/<realm-id>/<area>/object.yamlstructure).clientRoleflag is wrongly treated as a field and leads to warnings in log. This will be treated in File map storage: Role no-downtime store #13631 or perhaps sooner (FixOverwriting value of clientRole fieldlog message #16857).Fixes: #13632
Fixes: #15885