8000 Fix Flaky test: RequiredActionTotpSetupTest.setupTotpExistingReusableCodeDisabled by stianst · Pull Request #15779 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Fix Flaky test: RequiredActionTotpSetupTest.setupTotpExistingReusableCodeDisabled - #15779

Merged
stianst merged 2 commits into
keycloak:mainfrom
stianst:RequiredActionTotpSetupTest
Dec 1, 2022
Merged

stianst merged 2 commits into
keycloak:mainfrom
stianst:RequiredActionTotpSetupTest

Conversation

@stianst
@stianst stianst commented Dec 1, 2022 •
Copy link
Copy Markdown
Contributor

Previously this test worked like this:

  1. Configure and use code#1
  2. Set time offset, which has not effect as OTP doesn't use Keycloak Time util
  3. Generate code#2. This code most of the time is equal to code#1, but if test runs on the boarder of a time window can be different
  4. Expect login to fail as code#1 is the same as code#2, except as pointed out in 3 it isn't always the case

Before this change the test failed locally after ~10 runs, while with this change it's now passed 1000 times. Although it's pretty clear from reading the tests what the issue is without needing to reproduce it locally.

Closes #15564

@stianst
stianst merged commit 8e6437e into keycloak:main Dec 1, 2022
@stianst
stianst deleted the RequiredActionTotpSetupTest branch December 1, 2022 09:41
andre-nascimento6791 pushed a commit to andre-nascimento6791/keycloak-cnd-work that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: RequiredActionTotpSetupTest.setupTotpExistingReusableCodeDisabled

2 participants

0