8000 Use DELETE statement instead of deleting one by one for HotRod store by mhajas · Pull Request #15401 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Use DELETE statement instead of deleting one by one for HotRod store - #15401

Merged
hmlnarik merged 1 commit into
keycloak:mainfrom
mhajas:9420-Use-bulk-deletes-in-HotRod-store
Nov 11, 2022
Merged

hmlnarik merged 1 commit into
keycloak:mainfrom
mhajas:9420-Use-bulk-deletes-in-HotRod-store

Conversation

@mhajas
@mhajas mhajas commented Nov 8, 2022
Copy link
Copy Markdown
Contributor

Closes #9420

@mhajas mhajas added area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching team/storage-sig labels Nov 8, 2022
@mhajas
mhajas requested a review from martin-kanis November 8, 2022 16:16
@martin-kanis martin-kanis left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good, just one nitpick: AtomicLong import can be removed.

@mhajas
mhajas force-pushed the 9420-Use-bulk-deletes-in-HotRod-store branch from b978109 to 87902d2 Compare November 10, 2022 07:51
@hmlnarik hmlnarik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per @martin-kanis 's approval

@hmlnarik
hmlnarik merged commit 9944a59 into keycloak:main Nov 11, 2022
@mhajas
mhajas deleted the 9420-Use-bulk-deletes-in-HotRod-store branch November 11, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use bulk deletes in HotRod store

3 participants

0