Repository navigation
Conversation
f3116dd to
88d1e33
Compare
There was a problem hiding this comment.
Even though this Pull Request does not yet solve the issue to enforce the defaults on all clients. It is well done and ready to merge/review.
| } | ||
|
|
||
| if (configuration.allowOpen) { | ||
| if (!"dev".equals(System.getProperty("kc.profile"))) { |
There was a problem hiding this comment.
| if (!"dev".equals(System.getProperty("kc.profile"))) { | |
| if(!Environment.isDevProfile()){ |
There was a problem hiding this comment.
Hi @1-alex98
Thanks, currently Environment.isDevProfile is from keycloak-quarkus-server module which is not included in the keycloak-services module.
I think it better keep as it is and wait for Keycloak team to check.
Closes keycloak#14381 Signed-off-by: Lex Cao <lexcao@foxmail.com>
88d1e33 to
e12a6bd
Compare
|
@lexcao Thanks and sorry for late review. There was other PR (which was based on your PR): #25637 . That one was already merged in Keycloak main and will be available in Keycloak 24. So I am closing this PR. Unfortunately, your name disappeared from being co-author of the original commit, but I will make sure that you are mentioned in the release notes regarding this contribution. |
|
Finally, great, thanks! @mposolda |
Closes #14381