Repository navigation
JPA map storage: User / client session no-downtime store - #12241
Merged
Merged
Conversation
vramik
force-pushed
the
9666-user-client-sessio-store
branch
from
May 31, 2022 06:04
93bc998 to
bb3a8e9
Compare
vramik
force-pushed
the
9666-user-client-sessio-store
branch
from
June 9, 2022 09:44
9a93e6d to
7838a98
Compare
vramik
force-pushed
the
9666-user-client-sessio-store
branch
from
June 23, 2022 15:56
7838a98 to
4f94557
Compare
vramik
commented
Jun 23, 2022
vramik
force-pushed
the
9666-user-client-sessio-store
branch
from
June 23, 2022 16:55
4f94557 to
56db171
Compare
vramik
marked this pull request as ready for review
June 23, 2022 16:56
ahus1
reviewed
Jun 24, 2022
ahus1
requested changes
Jun 24, 2022
Member
There was a problem hiding this comment.
Hi @vramik - great work! I'm happy to see that all the uglies of my first attempts to tackle to concurrency problems are now gone.
See below for a comment about CockroachDB, and I wondered if the table kc_user_session_client_session would be necessary.
vramik
force-pushed
the
9666-user-client-sessio-store
branch
2 times, most recently
from
June 26, 2022 19:25
ff9d967 to
b0d9709
Compare
hmlnarik
reviewed
Jun 28, 2022
sguilhen
reviewed
Jun 28, 2022
vramik
force-pushed
the
9666-user-client-sessio-store
branch
4 times, most recently
from
July 13, 2022 19:38
6c07b35 to
97cf6fc
Compare
vramik
commented
Jul 13, 2022
vramik
commented
Jul 13, 2022
ahus1
reviewed
Jul 14, 2022
Member
There was a problem hiding this comment.
Hi @vramik - this looks great; the table structure with client and user sessions looks now a lot simpler! I tested it locally it it all works as expected.
With your comments, you identified the two locking scenarios that are different from the others places. I've added my replies there on where the locking should be moved.
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net> Closes keycloak#9666
vramik
force-pushed
the
9666-user-client-sessio-store
branch
from
July 14, 2022 10:08
97cf6fc to
3969abe
Compare
ahus1
self-requested a review
July 14, 2022 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9666