Repository navigation
Switch to StatefulSet - #12757
Switch to StatefulSet#12757
Conversation
There was a problem hiding this comment.
I'm not very comfortable with removing the errors checks here, but since it'll be addressed in #10285 in any case, I'm fine with it.
There was a problem hiding this comment.
For clarity, I couldn't find the equivalent Condition in the StatefulSet, I think it doesn't have an equivalent.
There was a problem hiding this comment.
I appreciate this check is needed but should we rather tweak the generic cleanup method rather than tackling it for just this one tests? Other tests (in the future) might need this tweak as well.
There was a problem hiding this comment.
I was thinking about ... the tradeoff here is that by making it generic we risk increasing every test execution time due to the extra checks
There was a problem hiding this comment.
tentatively keeping this implementation for now, not fussy around changing/improving it, but it can be done in a subsequent iteration. (e.g. I won't have time to test it right now)
39ef151 to
e6f819e
Compare
|
@vmuzikar should be ready for the next round 👍 |
e6f819e to
5c1d534
Compare
|
Rebase on latest |
Resolves #12700
I sneaked in a couple of improvements necessary to get the green CI:
app=keycloaklabeltestInitialAdminUserbetter isolation