Repository navigation
Conversation
|
@hmlnarik who should review this one? do you want someone from the store team to deal with it? |
There was a problem hiding this comment.
This PR is out of sync with the recent changes in #11933. Please see inline.
As a general rule, please use realm attributes to store the admin event timeout, and adjust admin UI javascript accordingly (applies to keycloak-admin-ui as well).
1792cc5 to
bc780eb
Compare
bc780eb to
3d0eabf
Compare
3d0eabf to
2d32bcf
Compare
There was a problem hiding this comment.
Thank you
8000
for the changes! The code is almost good, please see inline?
Could you please add a test similar to EventStoreProviderTest.clearOld testing this new functionality.
There was a problem hiding this comment.
Please note these changes should be also propagated to the new admin console, see https://github.com/keycloak/keycloak-ui.
Cc: @edewit @ssilvert Could you please advise here how to incorporate the changes here?
There was a problem hiding this comment.
Please note these changes should be also propagated to the new admin console, see https://github.com/keycloak/keycloak-ui. Cc: @edewit @ssilvert Could you please advise here how to incorporate the changes here?
Added issue in keycloak-ui repo. We will take care of it right after this is merged. You can ping me in the issue to let me know when that is done.
0fcd9d8 to
2dee316
Compare
|
@sschu It seems the last force push somehow reverted the changes I could see pushed yesterday, could you please check? |
2dee316 to
cddcea7
Compare
|
@hmlnarik The test failure is in |
There was a problem hiding this comment.
I agree. Thanks for the PR!
| <kc-tooltip>{{:: 'events.expiration.tooltip' | translate}}</kc-tooltip> | ||
| <div class="col-md-6 time-selector"> | ||
| <input class="form-control" type="number" data-ng-model="realm.attributes.adminEventsExpiration" id="adminEventsExpiration" name="adminEventsExpiration" min="0"/> | ||
| <select class="form-control" name="adminEventsExpirationUnit" data-ng-model="realm.attributes.adminEventsExpirationUnit"> |
There was a problem hiding this comment.
I didn't notice this before but why is this an attribute of the realm instead of one that's on the event config?
There was a problem hiding this comment.
@edewit What kind of event config do you mean? The expiration config for user events is already a column on the REALM table. The configuration for admin events was implemented similarly, just using a realm attribute in order to not have a schema change.
|
@hmlnarik Will do. |
|
@sschu Thank you! |
introduce expiration option for admin events
Fixes: #12476
Note for backport: Caused #14294