8000 Add how to install extensions to the container docs by andreaTP · Pull Request #11025 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add how to install extensions to the container docs - #11025

Merged
stianst merged 1 commit into
keycloak:mainfrom
andreaTP:add-extensions-to-container
Apr 8, 2022
Merged

stianst merged 1 commit into
keycloak:mainfrom
andreaTP:add-extensions-to-container

Conversation

@andreaTP
@andreaTP andreaTP commented Mar 31, 2022 •
Copy link
Copy Markdown
Contributor

Resolves #11049

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but I wonder if we should create a separate GH Issue for it as #10792 is specifically for adding a new operator guide. WDYT?

@andreaTP
Copy link
Copy Markdown
Contributor Author

@vmuzikar do you see much space for improvement? I think this guide is already enough and we can link it when we speak about the customImage field of the CR. wdyt?

@vmuzikar
vmuzikar commented Apr 1, 2022
Copy link
Copy Markdown
Contributor

@andreaTP I think we should still do a separate "Customize and optimize Keycloak deployments using the Operator" guide. It'd be short now, just describing that you should build your custom image (with the link to this guide) and describing that auto re-augmentation is disabled if you provide a custom image. We might add in the future an explanation of the seamless augmentation. I wouldn't e.g. hide these details in the "Advanced configuration" guide. WDYT?

@andreaTP
andreaTP commented Apr 1, 2022
Copy link
Copy Markdown
Contributor Author

@vmuzikar sounds good to me, changed the reference so that it won't close the issue when merged

@stianst
stianst merged commit 854b75e into keycloak:main Apr 8, 2022

FROM quay.io/keycloak/keycloak:latest
COPY --from=builder /opt/keycloak/lib/quarkus/ /opt/keycloak/lib/quarkus/
COPY --from=builder /opt/keycloak/ /opt/keycloak/
@armujahid armujahid Apr 23, 2022 •
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to copy full /opt/keycloak ? Can't we just copy ./lib/quarkus/ and ./providers instead?

COPY --from=builder /opt/keycloak/lib/quarkus/ /opt/keycloak/lib/quarkus/
COPY --from=builder /opt/keycloak/providers/ /opt/keycloak/providers/

@armujahid armujahid Apr 23, 2022 •
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get about ~200MB lighter image if I follow this approach instead of fully copying /opt/keycloak/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreaTP any answer to that question? Would also be interested in it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armujahid It should work fine because files at lib/quarkus are what really changes after a build.

If you want to send a PR with this suggestion to our guide, I'm happy to review it and make this more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detail how to include extensions in custom images in server docs

7 participants

0