Repository navigation
Properly enable/disable metrics and health endpoints - #11507
Merged
Merged
Conversation
pedroigor
force-pushed
the
issue-11506
branch
7 times, most recently
from
May 3, 2022 20:30
dfa8497 to
6c8b8f9
Compare
Contributor
|
cc @keycloak/kc-developers |
pedroigor
force-pushed
the
issue-11506
branch
2 times, most recently
from
June 9, 2022 15:12
9419f20 to
99efc96
Compare
pedroigor
force-pushed
the
issue-11506
branch
4 times, most recently
from
July 19, 2022 12:23
e78ba3e to
1fea26a
Compare
pedroigor
marked this pull request as ready for review
July 19, 2022 13:16
pedroigor
force-pushed
the
issue-11506
branch
4 times, most recently
from
July 19, 2022 20:31
9c97087 to
aee2d5e
Compare
DGuhr
suggested changes
Jul 21, 2022
Contributor
There was a problem hiding this comment.
hm, just thinking now: should we still promote the build so much, or use start instead with the new behaviour around optimized? wdyt? not hard on either, though
Contributor
Author
There was a problem hiding this comment.
I had the same thought and I initially started by using start (now we have pre-build by default). But I think we need to first see what it takes to update all guides and not a single one, in favor of consistency.
abstractj
previously approved these changes
Jul 21, 2022
pedroigor
force-pushed
the
issue-11506
branch
2 times, most recently
from
July 21, 2022 16:41
c071471 to
c444958
Compare
Closes keycloak#11506 Co-authored-by: Dominik Guhr <dguhr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11506
health/liveandhealth/readyendpoints to only show their specific checksKeycloakSessionevery time those endpoints are invoked. The current behavior is causing transactions to not disassociate from the calling thread and causing Arjuna to wait for them to timeout. Eventually, the server might block during the shutdown.KeycloakSecurityHeadersFilterin case the health and metrics endpoints are invoked where there is no session from the calling threadThere are many improvements to health and metrics we can do. This PR basically brings some consistency to what we have and fixes some known issues.
For health, we should be improving it as per #11556.