Repository navigation
Change tx driver handling. - #10378
Conversation
ab09df8 to
c76fabe
Compare
There was a problem hiding this comment.
What about the database tests? We have one using non-xa for MSSQL and I think it should be updated.
And we probably want to update another database test too such as mysql or postgres?
|
@pedroigor for updating existing test: sure, done. but the process is the same, we have a configuration test covering the mechanism and one "smoke" test using mysql with a non-xa driver. imo this suffices, but yes I can add more tests. Then again, a meaningful test would be to really spin up a database like mariadb_galera in a testcontainer that can only be used with non-xa. Should I work on that instead? Shouldn't be that hard I think. I have a working setup here: https://gist.github.com/DGuhr/59c17fc6ec461a5ec3421fa4bb8eacd8 I just want to avoid running too many tests testing kind of the same thing, as the time of the testsuite run is pretty high. but not sure. |
3a02c86 to
de562c9
Compare
|
@DGuhr More tests better. But we can do that as a follow-up because the mechanics are already being covered at some degree. |
de562c9 to
6015054
Compare
Introduce a non-tx driver for the vendors and map based on new build option transaction-tx-enabled Closes keycloak#10191 and others. Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
b4e6945 to
a654d96
Compare
|
Is there a (rough) ETA on the next release that includes this change? |
Introduce a non-tx driver for the vendors and map based on new build option transaction-tx-enabled
Closes #10191 and others.