Repository navigation
Conversation
Removes bulder.lower() from user search queries on email and username.
Closes<
8000
/span> keycloak#8893
Author
ahus1
self-requested a review
February 21, 2022 08:34
Member
|
@hmlnarik - for this first-time contributor, the GitHub actions don't run automatically. Please trigger the GitHub action run for this PR. Thanks! |
Member
|
LGTM from code review, did a local test with the UI for exact and wildcard search. Also tested the API as the UI doesn't trigger all code paths. Will defer the approval once I see the CI pass. |
Member
|
closed and re-opened to re-trigger the builds that were cancelled. |
ahus1
approved these changes
Mar 2, 2022
Member
There was a problem hiding this comment.
Relevant builds are now green, also tested it manually before (see previous comment).
B15A
hmlnarik
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes bulder.lower() from user search queries on email and username.
Closes #8893